[4.4] Fix display of total votes#43740
Conversation
|
I have tested this item ✅ successfully on 9ed4867 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43740. |
1 similar comment
|
I have tested this item ✅ successfully on 9ed4867 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43740. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43740. |
How can this be rtc while this is still outstanding to be fixed |
To me the code style seems to be ok, and PHPCS seems to be ok with it, too. |
|
Thanks for this PR and testing. Just a question. Who or what ensures that this PR also applies to J5? |
@sandewt Same as always for all bug fixes in 4.4-dev: When the PR has been merged into 4.4-dev, release managers of 5.1 will merge it up into 5.1-dev and so on. |
when you look at the entire file (not just the snippet shown in github) then you can see that @chmst is correct |
|
@Quy Thanks for fixing the CS. Leaving RTC status as the change after setting RTC was just a code style change, so previous human tests are still valid. @chmst Thanks for review, and thanks @ChristineWk and @viocassel for testing. |
|
Thank you! |
10 participants
Pull Request for Issue #43728. Regression of #42934.
Summary of Changes
Move the number of votes outside of the visually-hidden section so it can be visible.
Testing Instructions
Enable Voting in Articles component configuration.
Vote for one or more articles.
Edit
Content -Voteplugin.Toggle
Number of VotestoShow.Actual result BEFORE applying this Pull Request
Total number of votes is not visible.
Expected result AFTER applying this Pull Request
Total number of votes is visible.